Fix invalid UTF-8 in protobuf strings #5119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EOS supports having non-UTF8 attributes, which get returned in a
Stat
. This is problematic for us, as we pass these attributes in theArbitraryMetadata
, which gets sent over gRPC. However, the protobuf language specification states:An example of such an attribute is:
We fix this by stripping non-UTF8 metadata entries before sending the
ResourceInfo
over gRPC