Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose capability to deny access in OCS API #2733

Closed
wants to merge 3 commits into from
Closed

Expose capability to deny access in OCS API #2733

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
558631b
Expose capability to deny access in OCS API
gmgigi96 Jan 10, 2022
71366e3
Fix tests
gmgigi96 Apr 12, 2022
950b7b4
Add changelog
gmgigi96 Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@gmgigi96
gmgigi96 committed Apr 12, 2022
commit 71366e36f7769def18556d380514902eba12f999
5 changes: 1 addition & 4 deletions pkg/share/share.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import (
userv1beta1 "github.com/cs3org/go-cs3apis/cs3/identity/user/v1beta1"
collaboration "github.com/cs3org/go-cs3apis/cs3/sharing/collaboration/v1beta1"
provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1"
"github.com/cs3org/reva/internal/http/services/owncloud/ocs/conversions"
"github.com/cs3org/reva/pkg/utils"
"google.golang.org/genproto/protobuf/field_mask"
)
Expand Down Expand Up @@ -118,9 +117,7 @@ func MatchesFilter(share *collaboration.Share, filter *collaboration.Filter) boo
case collaboration.Filter_TYPE_GRANTEE_TYPE:
return share.Grantee.Type == filter.GetGranteeType()
case collaboration.Filter_TYPE_EXCLUDE_DENIALS:
// This filter type is used to filter out "denial shares". These are currently implemented by having the permission "0".
// I.e. if the permission is 0 we don't want to show it.
return int(conversions.RoleFromResourcePermissions(share.Permissions.Permissions).OCSPermissions()) != 0
return share.Permissions.Permissions.DenyGrant
default:
return false
}
Expand Down