-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: multi-sign batch command is not exposed and tested (#422) #438
Conversation
7657043
to
14edf68
Compare
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 20.74% 22.94% +2.19%
==========================================
Files 54 54
Lines 8565 8682 +117
==========================================
+ Hits 1777 1992 +215
+ Misses 6213 6119 -94
+ Partials 575 571 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the liquid supply test fails: https://github.com/crypto-org-chain/chain-main/pull/438/checks?check_run_id=2224687315#step:5:389
I guess because 4000cro were added to the default network?
I'll check |
14edf68
to
796156d
Compare
solution: add
multisign-batch
in tx subcommand and integration test