Problem: duplicate commands(#421) #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtau
reviewed
Mar 22, 2021
| @@ -228,9 +228,6 @@ func txCommand() *cobra.Command { | |||
| authcmd.GetBroadcastCommand(), | |||
| authcmd.GetEncodeCommand(), | |||
| authcmd.GetDecodeCommand(), | |||
| flags.LineBreak, | |||
| vestingcli.GetTxCmd(), | |||
| subscriptioncli.NewTxCmd(), | |||
There was a problem hiding this comment.
is subscription duplicated?
There was a problem hiding this comment.
yes, it's duplicated too
linfeng-crypto
force-pushed
the
issue-421
branch
from
575553d to
a433d71
Compare
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 23.10% 23.08% -0.03%
==========================================
Files 55 55
Lines 8742 8739 -3
==========================================
- Hits 2020 2017 -3
Misses 6154 6154
Partials 568 568
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
don34
approved these changes
Mar 22, 2021
tomtau
approved these changes
Mar 23, 2021
tomtau
added a commit
that referenced
this pull request
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution: remove the duplicate commands