Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage #81

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Test coverage #81

merged 2 commits into from
Oct 14, 2023

Conversation

Bchass
Copy link
Contributor

@Bchass Bchass commented Oct 13, 2023

This takes care of: #80

Updated:

  • CONTRIBUTING.md
  • Added pinned version in pyproject.toml
  • Added pinned version in requirements.txt

@Bchass
Copy link
Contributor Author

Bchass commented Oct 13, 2023

Can't say I've seen ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device before

@Bchass
Copy link
Contributor Author

Bchass commented Oct 13, 2023

@audreyfeldroy
Copy link
Member

Amazing! Thank you so much for this @Bchass. I just merged in @Subramaniam-dot's PR which included an improvement to the GitHub action to free up some device space. Try rebasing and rerunning the checks.

@Bchass
Copy link
Contributor Author

Bchass commented Oct 13, 2023

Amazing! Thank you so much for this @Bchass. I just merged in @Subramaniam-dot's PR which included an improvement to the GitHub action to free up some device space. Try rebasing and rerunning the checks.

Should be all set now

@Bchass
Copy link
Contributor Author

Bchass commented Oct 13, 2023

This just occurred to me, do we want coverage running and showing a report in actions too (this could lead to a coverage badge in the README)? Or just leave it to a user to run the commands themself?

@audreyfeldroy
Copy link
Member

Ooh being able to view a coverage report from a GitHub action would be such a huge help @Bchass. Let me review/merge this PR and then if you'd like you can file an issue for that, or just submit a PR?

Copy link
Member

@audreyfeldroy audreyfeldroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, I see coverage was already in there. Thanks for pinning it and documenting, this helps us all out a lot!

@audreyfeldroy audreyfeldroy merged commit b30831d into crisishistory:main Oct 14, 2023
@audreyfeldroy
Copy link
Member

The Readme coverage button would be awesome too 👍

@Bchass Bchass deleted the test_coverage branch October 14, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants