Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): write unbonding period advisory to stderr instead of stdout #1921

Merged
merged 2 commits into from
May 27, 2024
+4 −1
Merged

fix(client): write unbonding period advisory to stderr instead of stdout #1921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc2ce12
fix(client): write unbonding period advisory to stderr instead of stdout
chris-ricketts May 24, 2024
8ae6ac4
Add changelog for unbonding period advisory
p-offtermatt May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/1921-write-stderr.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Write unbonding period advisory to stderr instead of stdout
([\#1921](https://github.com/cosmos/interchain-security/pull/1921))
Comment on lines +1 to +2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry clearly describes the changes made. However, it should end with a newline character to comply with common text file standards.

+
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- Write unbonding period advisory to stderr instead of stdout
([\#1921](https://github.com/cosmos/interchain-security/pull/1921))
- Write unbonding period advisory to stderr instead of stdout
([\#1921](https://github.com/cosmos/interchain-security/pull/1921))

3 changes: 2 additions & 1 deletion x/ccv/provider/client/proposal_handler.go
View file
Original file line number Diff line number Diff line change
@@ -363,7 +363,8 @@ func CheckPropUnbondingPeriod(clientCtx client.Context, propUnbondingPeriod time
providerUnbondingTime := res.Params.UnbondingTime

if providerUnbondingTime < propUnbondingPeriod {
fmt.Printf(
fmt.Fprintf(
os.Stderr,
`consumer unbonding period is advised to be smaller than provider unbonding period, but is longer.
This is not a security risk, but will effectively lengthen the unbonding period on the provider.
consumer unbonding: %s
Loading