Put the path choices in clients instead of spec-wide #293
Conversation
|
|
Note that this also makes the canonical encoding client-type-specific, which I think is desirable. |
|
Merging since we concurred in the meeting & I want to avoid conflicts. Glad to walk anyone through. |
| height: uint64, | ||
| proof: CommitmentProof, | ||
| connectionIdentifier: Identifier, | ||
| connectionEnd: ConnectionEnd) { |
There was a problem hiding this comment.
The second connectionEnd is the part actually being verified.
The first is the local connection.
| proof: CommitmentProof, | ||
| connectionIdentifier: Identifier, | ||
| connectionEnd: ConnectionEnd) { | ||
| client = queryClient(connection.clientIdentifier) |
There was a problem hiding this comment.
Why? The idea is that the client exposes this function.
| connectionIdentifier: Identifier, | ||
| connectionEnd: ConnectionEnd) { | ||
| client = queryClient(connection.clientIdentifier) | ||
| return client.verifyConnectionState(connection, height, connection.counterpartyPrefix, proof, connectionIdentifier, connectionEnd) |
There was a problem hiding this comment.
should be
client.verifyConnectionState(clientState, height, connection.counterpartyPrefix, proof, connection.Identifier, connection)| connection: ConnectionEnd, | ||
| height: uint64, | ||
| proof: CommitmentProof, | ||
| connectionIdentifier: Identifier, |
There was a problem hiding this comment.
Yes, we need to know the identifier to verify under.
| path: Path, | ||
| value: Value): bool { | ||
| clientIdentifier: Identifier, | ||
| consensusState: ConsensusState) { | ||
| client = queryClient(connection.clientIdentifier) |
| client = queryClient(connection.clientIdentifier) | ||
| client.verifyMembership(height, proof, applyPrefix(connection.counterpartyPrefix, path), value) | ||
| return client.verifyClientConsensusState(connection, height, connection.counterpartyPrefix, proof, clientIdentifier, consensusState) |
There was a problem hiding this comment.
return client.verifyClientConsensusState(clientState, height, connection.counterpartyPrefix, proof, clientState.Identifier, consensusState)
| portIdentifier: Identifier, | ||
| channelIdentifier: Identifier, | ||
| channelEnd: ChannelEnd) { | ||
| path = applyPrefix(prefix, "ports/{portIdentifier}/channels/{channelIdentifier}") |
There was a problem hiding this comment.
question: why do we want to expose the paths hardcoded on the client? do we expect ICS02 to be customized? Why not pass the path param directly instead of the prefix?
There was a problem hiding this comment.
These are example implementations, not necessarily required.
They will vary per client type. See #286
Closes #288