Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check client status active when verifying membership on tenderm… #5865

Conversation

duvbell
Copy link
Contributor

@duvbell duvbell commented Feb 19, 2024

Description

closes: #5847

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@duvbell duvbell marked this pull request as draft February 19, 2024 16:28
@damiannolan
Copy link
Contributor

damiannolan commented Feb 20, 2024

Hi @kienn6034, I am going to ahead and close this PR as I had started work on this issue previously, and pushed the code this morning (see: #5870). Sorry about that!

In future, we would kindly ask that you comment on an issue before working on it so that we can assign you and prevent situations like this from happening. This is documented in the ibc-go CONTRIBUTING.md doc. Thanks for your work none the less, it is appreciated! There will be plenty of more issues to work on in the future if you are interested in contributing to the repository! ❤️

@duvbell
Copy link
Contributor Author

duvbell commented Feb 21, 2024

Thank you @damiannolan. Will do next time, it is my first time contributing to ibc-go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check client status on VerifyMembership rpc
2 participants