feat: migration to gov v1 #4620
Merged
+2,637
−1,927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add proto message for Recover client, implement sdk.Message interface. * Update modules/core/02-client/types/msgs.go Co-authored-by: Damian Nolan <[email protected]> * Apply suggestions from code review Co-authored-by: Charly <[email protected]> * Remove gogoproto false for cmp, lint, move ibctesting address inline. --------- Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Charly <[email protected]>
…ce proposals (#4436) * add protos and keeper function placeholder * add keeper functions/tests, msgs and tests
* Add 02-client implementation for Recover client. * Partially address feedback. * Docu RecoverClient, add label, re-use error.
* Add message server handler for recovering a client * Don't assign to deprecated attrs, clean up unused fields. * Further clean-up, remove declaration of unmutated vars.
* Add cmd for submitting a recover client prop. * Bump cosmossdk in e2e. * Use govtypes.ModuleName, rename old govtypes to govv1beta1 * Update modules/core/02-client/client/cli/tx.go Co-authored-by: Damian Nolan <[email protected]> * Add auth flag. --------- Co-authored-by: Damian Nolan <[email protected]>
chore: bump feat/govv1
Co-authored-by: Colin Axnér <[email protected]>
* docs: recover client update * Update docs/ibc/proposals.md * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <[email protected]> --------- Co-authored-by: Carlos Rodriguez <[email protected]>
* refactor: remove legacy client update proposal * e2e: swap from ClientUpdateProposal e2e to RecoverClient * refactor: remove unused events
Co-authored-by: colin axner <[email protected]>
…ed client (#4594) * add new event type * update event name
colin-axner
commented
Sep 11, 2023
2 tasks
damiannolan
approved these changes
Sep 11, 2023
* wip e2e test * query proposal * update upgrade height in plan * rm unnecessary wait/authority * rm test artifact from merge * add checks for scheduled plan * hook up upgrade query client * plan height * pr fixes * update test * import space * update newchainID value * update clientID upgrade * linter * gci * rm unnecessary event --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: colin axnér <[email protected]> Co-authored-by: Sishir Giri <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Jim Fasarakis-Hilliard <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: catShaark <[email protected]> Co-authored-by: khanh-notional <[email protected]>
* chore: update docs for UpgradeProposal -> MsgIBCSoftwareUpgrade * chore: anticipate link change * fix event docs
colin-axner
commented
Sep 11, 2023
|
I noticed the ordering of the msgs is inconsistent, I will update as follows: |
…aviour, recover, ibcsoftwareupgrade, update params
5 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4620 +/- ##
==========================================
+ Coverage 79.27% 79.44% +0.16%
==========================================
Files 188 188
Lines 13046 13109 +63
==========================================
+ Hits 10342 10414 +72
+ Misses 2270 2265 -5
+ Partials 434 430 -4
|
damiannolan
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
ACK latest 👍
Thanks @colin-axner! And thank you to @charleenfei and @DimitrisJim for their work on the feat branch! ❤️
charleenfei
reviewed
Sep 11, 2023
There was a problem hiding this comment.
thanks for opening this and fixing up conflicts @colin-axner !
colin-axner
commented
Sep 11, 2023
Co-authored-by: Charly <[email protected]>
|
self ACK on the changes |
# Conflicts: # e2e/tests/core/02-client/client_test.go
crodriguezvega
approved these changes
Sep 12, 2023
chatton
approved these changes
Sep 12, 2023
| @@ -242,97 +245,145 @@ func NewUpgradeClientCmd() *cobra.Command { | |||
| return cmd | |||
| } | |||
|
|
|||
| // NewCmdSubmitUpdateClientProposal implements a command handler for submitting an update IBC client proposal transaction. | |||
| func NewCmdSubmitUpdateClientProposal() *cobra.Command { | |||
| // newSubmitRecoverClientProposalCmd defines the command to recover an IBC light client | |||
There was a problem hiding this comment.
Suggested change
| // newSubmitRecoverClientProposalCmd defines the command to recover an IBC light client | |
| // newSubmitRecoverClientProposalCmd defines the command to recover an IBC light client. |
| AddRoute(paramproposal.RouterKey, params.NewParamChangeProposalHandler(app.ParamsKeeper)). | ||
| AddRoute(ibcclienttypes.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper)) | ||
|
|
||
| AddRoute(paramproposal.RouterKey, params.NewParamChangeProposalHandler(app.ParamsKeeper)) |
There was a problem hiding this comment.
@damiannolan brought this up in the docs review, is the NewParamChangeProposalHandler still required?
There was a problem hiding this comment.
Probably not. maybe we can remove in a followup since it should have been removed with param migration?
There was a problem hiding this comment.
can hold off on merging #4628 until then I think
modules/core/keeper/msg_server.go
Outdated
| } | ||
|
|
||
| if err = k.ClientKeeper.ScheduleIBCSoftwareUpgrade(ctx, msg.Plan, upgradedClientState); err != nil { | ||
| return nil, errorsmod.Wrapf(err, "cannot schedule IBC client upgrade") |
There was a problem hiding this comment.
Suggested change
| return nil, errorsmod.Wrapf(err, "cannot schedule IBC client upgrade") | |
| return nil, errorsmod.Wrap(err, "cannot schedule IBC client upgrade") |
I believe Wrapf expects format args
9 tasks
4 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1282
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.