upgrade to go 1.20 and newer protobuf builder to reduce v50 changeset #3811
Conversation
faddat
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan,
chatton and
DimitrisJim
as code owners
There was a problem hiding this comment.
Thank you, @faddat! I think it would be nice to take out the bump to SDK v0.47.3 out of this PR (since you have that covered in #3810) and then the scope of this PR will very nicely be scope to bumping go version and protobuf builder version. :)
If these are changes required for SDK v0.50. Should we target this PR to the feature branch?
|
Hey Carlos, I'm very happy to do that. I will take care of that right now. |
|
...btw I do have a question -- I could not really figure out why the capabilities module does not build here, do you have any ideas? |
Looks like it's building now, right? |
|
I'll make it single quotes because following the recommendations is great :) |
|
Hi, was this commit dd3b04b supposed to turn the quotes into single quotes or is the intention to do it in a followup commit? |
|
Hey Colin, yeah that was definitely supposed to be single quotes and I think that I should just revert that commit, I'm not sure how it ended up that way Thanks for your review! |
|
So what ended up being necessary was just reconfiguring my editor to use single quotes in YAML by default. When I did the flub commit before, it was because my editor was changing the singles to doubles when I saved the file. |
This PR uses go 1.20 and the latest protobuf builder so that the changeset for
v50 is smaller. This is the same intent as the earlier thelper PR, basically to
reduce the total number of changes that will be present in the v50 pr.