Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow chains that can't introspect their own ConsensusState support IBC #2419

Merged
merged 7 commits into from
Dec 27, 2022
Merged

Allow chains that can't introspect their own ConsensusState support IBC #2419

merged 7 commits into from
Dec 27, 2022
+5 −0

Conversation

seunlanlege
Copy link
Contributor

@seunlanlege
extend 03-connection proto with extra data for state machines that ca…

Verified

This commit was signed with the committer’s verified signature.
seunlanlege Seun Lanlege
GPG key ID: 79758E9B2C502ACD
Verified
Learn about vigilant mode
fe4031f 
…n't introspect their own consensus state
@seunlanlege seunlanlege changed the title Allow chains that can't introspect their own consensus state support IBC Allow chains that can't introspect their own ConsensusState support IBC Sep 28, 2022
crodriguezvega
crodriguezvega reviewed Dec 19, 2022
View reviewed changes
@crodriguezvega
Merge branch 'main' into main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ad51f5c
@crodriguezvega
update field name

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5eb10f0
@crodriguezvega
add changelog for cosmos#2419

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b038e0b
@crodriguezvega
Merge branch 'main' into main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f0d60c4
AdityaSripal
AdityaSripal approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seunlanlege

@crodriguezvega
Merge branch 'main' into main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c19d666
@crodriguezvega
Merge branch 'main' into main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f5aa9c7
@crodriguezvega crodriguezvega merged commit 48efd8e into cosmos:main Dec 27, 2022
@en
Copy link

en commented Jul 7, 2023

Hi @seunlanlege and @AdityaSripal,
Why don't we define this field as optional? I think the cosmos-sdk based chain should not need this field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega

@AdityaSripal AdityaSripal

@colin-axner colin-axner

@damiannolan damiannolan

@charleenfei charleenfei

@chatton chatton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seunlanlege @en @crodriguezvega @AdityaSripal