Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "withdraw-all-rewards" command when "--generate-only" is supplied #4872

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 8, 2019

closes: #4870


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #4872 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4872      +/-   ##
==========================================
- Coverage   54.31%   54.29%   -0.02%     
==========================================
  Files         271      271              
  Lines       17344    17346       +2     
==========================================
- Hits         9420     9418       -2     
- Misses       7226     7230       +4     
  Partials      698      698

@alexanderbez alexanderbez merged commit 745f2eb into master Aug 8, 2019
@alexanderbez alexanderbez deleted the bez/4870-disable-gen-only-withdraw-all-cmd branch August 8, 2019 15:51
alexanderbez added a commit that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'withdraw-all-rewards' Transaction Creation Error on gaiacli
2 participants