Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/tx): add enum as string encoder option #19618

Merged
merged 8 commits into from
Mar 5, 2024
+113 −31
Merged

feat(x/tx): add enum as string encoder option #19618

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9bfae4c
feat(x/tx): add enum as string encoder option
julienrbrt Mar 1, 2024
8b61e3b
changelogs
julienrbrt Mar 1, 2024
7bb9c9a
updates
julienrbrt Mar 1, 2024
a05eebd
follow sdk semver
julienrbrt Mar 1, 2024
28f7b8e
Merge branch 'main' into julien/enum-as-string
julienrbrt Mar 4, 2024
4dbd031
feedback
julienrbrt Mar 5, 2024
aae9611
use released modules
julienrbrt Mar 5, 2024
e568ffd
comment
julienrbrt Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
feedback
@julienrbrt
julienrbrt committed Mar 5, 2024

Verified

This commit was signed with the committer’s verified signature.
julienrbrt
GPG key ID: AEA8C21E608F1D02
Verified
Learn about vigilant mode
commit 4dbd031f3f6d49875af62f955d47d206de3c6de9
12 changes: 6 additions & 6 deletions x/tx/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -113,18 +113,18 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Improvements

* [#15871](https://github.com/cosmos/cosmos-sdk/pull/15871)
* `HandlerMap` now has a `DefaultMode()` getter method
* Textual types use `signing.ProtoFileResolver` instead of `protoregistry.Files`
* `HandlerMap` now has a `DefaultMode()` getter method
* Textual types use `signing.ProtoFileResolver` instead of `protoregistry.Files`

## v0.6.0

### API Breaking

* [#15709](https://github.com/cosmos/cosmos-sdk/pull/15709):
* `GetSignersContext` has been renamed to `signing.Context`
* `GetSigners` now returns `[][]byte` instead of `[]string`
* `GetSignersOptions` has been renamed to `signing.Options` and requires `address.Codec`s for account and validator addresses
* `GetSignersOptions.ProtoFiles` has been renamed to `signing.Options.FileResolver`
* `GetSignersContext` has been renamed to `signing.Context`
* `GetSigners` now returns `[][]byte` instead of `[]string`
* `GetSignersOptions` has been renamed to `signing.Options` and requires `address.Codec`s for account and validator addresses
* `GetSignersOptions.ProtoFiles` has been renamed to `signing.Options.FileResolver`

### Bug Fixes

1 change: 1 addition & 0 deletions x/tx/signing/aminojson/aminojson.go
View file
Original file line number Diff line number Diff line change
@@ -44,6 +44,7 @@ func NewSignModeHandler(options SignModeHandlerOptions) *SignModeHandler {
h.encoder = NewEncoder(EncoderOptions{
FileResolver: options.FileResolver,
TypeResolver: options.TypeResolver,
EnumAsString: false, // ensure enum as string is disabled
})
} else {
h.encoder = *options.Encoder
1 change: 1 addition & 0 deletions x/tx/signing/aminojson/json_marshal.go
View file
Original file line number Diff line number Diff line change
@@ -29,6 +29,7 @@ type EncoderOptions struct {
// DoNotSortFields when set turns off sorting of field names.
DoNotSortFields bool
// EnumAsString when set will encode enums as strings instead of integers.
// Caution: Enabling this option produce different sign bytes.
EnumAsString bool
// TypeResolver is used to resolve protobuf message types by TypeURL when marshaling any packed messages.
TypeResolver signing.TypeResolver
Loading