Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: server v2 #19413

Closed
wants to merge 97 commits into from
Closed

feat: server v2 #19413

wants to merge 97 commits into from

Conversation

tac0turtle
Copy link
Member

Description

This is a draft pr of server v2 into main, it is used to track changes occurring on main

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

tac0turtle and others added 30 commits January 15, 2024 16:53
@tac0turtle
refactor: modularize grpc server (#18284)
bd6f2e5
@tac0turtle
server: separate modules for web & gateway (#18335)
43d2a88
@tac0turtle
refactor(server): add tx codec and validation (#18416)
33a5024
@tac0turtle
move v2 into server
50d6223
@tac0turtle
feat: introduce app manager (#18690)
6dee4e4 
Co-authored-by: unknown unknown <unknown@unknown>
@tac0turtle
chore: create go mods for server v2 (#18825)
6df841a 
Co-authored-by: unknown unknown <unknown@unknown>
@testinginprod @tac0turtle
refactor(serverv2): make AppManager not depend on STF internal behavi…
93cd034 
…ours (#18845)

Co-authored-by: Marko <[email protected]>
Co-authored-by: unknown unknown <unknown@unknown>
@tac0turtle
feat(server/v2): add preparehandler code (#18873)
a9f83c9
@tac0turtle
feat(server/v2): add Verify block call (#18904)
080c84e
@tac0turtle
feat(server/v2): add valsetupdate API (#18923)
2a5492d
@tac0turtle
feat(server/v2): separate commit from deliverblock (#18924)
ee37cf9
@testinginprod @tac0turtle
feat(stf): Add PostTx Handler (#18928)
5bf212a 
Co-authored-by: unknown unknown <unknown@unknown>
@tac0turtle
go mod tidy
c139b22
@tac0turtle
refactor(server/v2): remove sdk as a dependency from server/v2 (#18905)
b681b79
@tac0turtle
chore(server/v2): create go.mod for appmanager (#18943)
c35d91b
@tac0turtle
feat(server/v2): add in streaming manager (#18934)
8608729
@tac0turtle
quick change for core to avoid extra imports
6d104d9
@tac0turtle
chore(server/v2): add gas wrapper (#18951)
e883f86
@tac0turtle
feat(server/v2): recovery (#18935)
1c0c9b9
@tac0turtle
feat(server/v2): Add upgradeblock (#18931)
c310119 
Co-authored-by: unknown unknown <unknown@unknown>
@tac0turtle
lint fixes
15e3388
@tac0turtle
chore(server/v2): cleanup reflection (#18964)
9091cf1
@testinginprod @tac0turtle
add(appmanager): storev2 integration (#18966)
e7e826b 
Co-authored-by: unknown unknown <unknown@unknown>
@testinginprod @tac0turtle
feat(serverv2): Add TX codec adjustments (#19013)
f722bc8 
Co-authored-by: unknown unknown <unknown@unknown>
@tac0turtle
feat(serverv2): modularize Comet (#18554)
4bfe027
@tac0turtle
feat(serverv2): comet polish (#19064)
fb24056 
Co-authored-by: unknown unknown <unknown@unknown>
@tac0turtle
go mod tidy
8086bd1
@tac0turtle
fix errors
d810a86
@tac0turtle
chore(server/v2/cometbft): add streaming (#19066)
0396da7
@tac0turtle
chore(server/v2): add todos from team meeting (#19074)
0cee2c3
@github-actions github-actions bot added C:Confix Issues and PR related to Confix C:Hubl Tool: Hubl C:x/epochs labels Apr 9, 2024
@github-actions github-actions bot removed C:Simulations C:x/crisis C:x/genutil genutil module issues C:Cosmovisor Issues and PR related to Cosmovisor C:orm Type: ADR C:collections C:Confix Issues and PR related to Confix C:Hubl Tool: Hubl labels Apr 9, 2024
@kocubinski @tac0turtle @testinginprod
server/v2: simapp v2 start (#19888)
24535d7 
Co-authored-by: Marko <[email protected]>
Co-authored-by: testinginprod <[email protected]>
Co-authored-by: testinginprod <[email protected]>
Co-authored-by: Marko <[email protected]>
@github-actions github-actions bot added the C:x/genutil genutil module issues label Apr 11, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 11, 2024
View reviewed changes
server/v2/cometbft/utils.go
// GetConsensusParams makes a query to the consensus module in order to get the latest consensus
// parameters from committed state
func (c *Consensus[T]) GetConsensusParams(ctx context.Context) (*cmtproto.ConsensusParams, error) {
cs := &cmtproto.ConsensusParams{}

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of cs is never used.
server/v2/cometbft/mock_store.go
}

func (s *MockStore) Query(storeKey []byte, version uint64, key []byte, prove bool) (storev2.QueryResult, error) {
state, err := s.Storage.StateAt(version)

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of err is never used.
server/v2/cometbft/mock_store.go

func (s *MockStore) Query(storeKey []byte, version uint64, key []byte, prove bool) (storev2.QueryResult, error) {
state, err := s.Storage.StateAt(version)
reader, err := state.GetReader(storeKey)

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of err is never used.
github-advanced-security[bot]
github-advanced-security bot found potential problems May 1, 2024
View reviewed changes
server/v2/cometbft/utils.go
evidence[i] = &consensus.Evidence{
EvidenceType: consensus.MisbehaviorType(e.Type),
Height: e.Height,
Time: &e.Time,

Check failure

Code scanning / gosec

Implicit memory aliasing in for loop. Error

Implicit memory aliasing in for loop.
runtime/v2/manager.go
return fmt.Errorf("failed to unmarshal %s genesis state: %w", moduleName, err)
}
for _, jsonTx := range genesisState.GenTxs {
txHandler(jsonTx)

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.
github-advanced-security[bot]
github-advanced-security bot found potential problems May 1, 2024
View reviewed changes
server/v2/cometbft/utils.go
// parameters from committed state
func (c *Consensus[T]) GetConsensusParams(ctx context.Context) (*cmtproto.ConsensusParams, error) {
cs := &cmtproto.ConsensusParams{}
latestVersion, err := c.store.GetLatestVersion()

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of err is never used.
@tac0turtle
Copy link
Member Author

closing this for now since we are starting to upstream things

@tac0turtle tac0turtle closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:CLI C:Store C:x/accounts C:x/auth C:x/authz C:x/bank C:x/circuit C:x/consensus C:x/distribution distribution module related C:x/epochs C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/protocolpool C:x/slashing C:x/staking C:x/tx C:x/upgrade Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tac0turtle @yihuang @testinginprod @facundomedica @julienrbrt @likhita-809 @kocubinski @hieuvubk