style: various linting fixes #15675
style: various linting fixes #15675
Conversation
github-prbot
requested review from
a team,
kocubinski and
alexanderbez
and removed request for
a team
| Amino = codec.NewLegacyAmino() | ||
| ModuleCdc = codec.NewAminoCodec(Amino) | ||
| ) | ||
| var Amino = codec.NewLegacyAmino() |
There was a problem hiding this comment.
Given that this ModuleCdc was exported, we need an API breaking changelog for it, and tell that Amino is now public.
Chains were doing as the SDK and named their module codec ModuleCdc as well (https://github.com/search?type=code&auto_enroll=true&q=%22.ModuleCdc%22+language%3AGo&l=Go).
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
| amino = codec.NewLegacyAmino() | ||
| ModuleCdc = codec.NewAminoCodec(amino) | ||
| ) | ||
| var amino = codec.NewLegacyAmino() |
There was a problem hiding this comment.
Shouldn't this one be public now?
There was a problem hiding this comment.
why was moduleCdc public? its only used internally.
There was a problem hiding this comment.
🤷🏾♂️ it is just that someone could have been relying on a module's ModuleCdc now. And that you've made some of them now public, and some others not.
There was a problem hiding this comment.
if possible id rather break this for people and tell them to use the tx encode/decode apis
There was a problem hiding this comment.
Sure, but then I'd argue that we should break them consistently.
Some Amino variable la that have been put public in this PR should be put back private.
There was a problem hiding this comment.
true, ill do it in a follow up pr
| amino = codec.NewLegacyAmino() | ||
| ModuleCdc = codec.NewAminoCodec(amino) | ||
| ) | ||
| var aminoCdc = codec.NewLegacyAmino() |
Co-authored-by: Facundo Medica <[email protected]>
julienrbrt
added
the
A:automerge
Description
fix various linting issues
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change