Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Try fix group sims issue #11458

Merged
merged 8 commits into from
Mar 25, 2022
Merged

fix: Try fix group sims issue #11458

merged 8 commits into from
Mar 25, 2022

Conversation

amaury1093
Copy link
Contributor

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 marked this pull request as ready for review March 25, 2022 10:33
@amaury1093 amaury1093 changed the title DNM: Try fix group sims issue fix: Try fix group sims issue Mar 25, 2022
blushi
blushi reviewed Mar 25, 2022
View reviewed changes
@amaury1093 amaury1093 merged commit 617cc6b into marie/11245-prune-group Mar 25, 2022
@amaury1093 amaury1093 deleted the am/11245-fix-sims branch March 25, 2022 11:02
blushi added a commit that referenced this pull request Mar 25, 2022
@blushi @amaury1093
fix: Various group fixes (#11404)
b31d67d 
* Rm TallyVotesInvariant

* Update TallyVotesSumInvariant to check for proposal voting period end

* Do not check for updated group and group policy on Vote

* Do not check for updated group and group policy on Exec

* Test invariants

* Update TallyVotesSumInvariant to check proposal status

* Add back invariants

* Nit

* Fix invariant

* Fix it.Close()

* Update docs

* Fix genesis sim

* Test genesis

* Test UpdateTallyOfVPEndProposals

* Do proposals update after index iterator closed in UpdateTallyOfVPEndProposals

* fix: Try fix group sims issue (#11458)

* Fix sims?

* Remove useless index

* Add comment

* Fix iterateProposalsByVPEnd

* Fix some other places

* Fix build

* Add unit test

* Use iterateProposalsByVPEnd again

Co-authored-by: Amaury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blushi blushi blushi approved these changes

@aleem1314 aleem1314 aleem1314 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amaury1093 @blushi @aleem1314