Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: snapshot & restore #11330

Closed
wants to merge 3 commits into from
Closed

cmd: snapshot & restore #11330

wants to merge 3 commits into from

Conversation

tac0turtle
Copy link
Member

Description

Closes: #10198


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the title cmd: snapshot & restpre cmd: snapshot & restore Mar 7, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tac0turtle
Copy link
Member Author

closing this for now, ill reopen when I can work on it

@tac0turtle tac0turtle closed this May 9, 2022
@yihuang
Copy link
Collaborator

yihuang commented May 11, 2022

this feature looks nice, what's the main thing missing, maybe we can help with this @marbar3778

@yihuang
Copy link
Collaborator

yihuang commented May 11, 2022

we also need to update the tendermint sync state to the same block height?

@tac0turtle tac0turtle deleted the 10198-restoror branch February 13, 2023 14:49
@baabeetaa
Copy link

this cmd is very useful for node operator

@tac0turtle
Copy link
Member Author

i agree, its blocked on a feature from comet though

@baabeetaa
Copy link

i agree, its blocked on a feature from comet though

do you think a seperated tool could do the job?

@tac0turtle
Copy link
Member Author

i tried to hack it and force comet and sdk to use it. Got close but then didnt complete it. Its a hardcocre hack. I can dig up that code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable easy rolling back to your own local statesync snapshot
3 participants