Enforce query response size limit after decompression in query-frontend #6607
+116
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
afhassan
force-pushed
the
qfe-byte-limit
branch
from
4b1de34 to
967ef4f
Compare
yeya24
reviewed
Mar 3, 2025
| validation.SmallestPositiveIntPerTenant(tenantIDs, c.limits.MaxFetchedDataBytesPerQuery), | ||
| ) | ||
|
|
||
| maxByteSize := validation.SmallestPositiveIntPerTenant(tenantIDs, c.limits.MaxFetchedDataBytesPerQuery) |
There was a problem hiding this comment.
Why do we use the same data bytes limit here instead of introducing a new limit?
There was a problem hiding this comment.
This limit config is under the limits section, so I thought it is more appropriate to use instead of creating a QFE specific limit config. We can update the description to mention that it is applied in query-frontend as well.
# The maximum combined size of all data that a query can fetch from each
# ingester and storage. This limit is enforced in the querier, ruler, **and query-frontend** for
# `query`, `query_range` and `series` APIs. 0 to disable.
# CLI flag: -querier.max-fetched-data-bytes-per-query
[max_fetched_data_bytes_per_query: <int> | default = 0]
I am okay with introducing another limit instead, but should it go under query-frontend section or limits section?
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## master / unreleased | |||
| * [ENHANCEMENT] Query Frontend: Limit query response size after decompression in query frontend. #6607 | |||
There was a problem hiding this comment.
Changelog items are ordered in certain way. https://github.com/cortexproject/cortex/blob/master/RELEASE.md#prepare-your-release
yeya24
reviewed
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
If
max_fetched_data_bytes_per_queryis configured, fail query response returned to query-frontend if the size of the response after decompression exceeds limit. Decompression reader stops once the max bytes limit is reached.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]