Migrate from dep -> go mod #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bltavares
force-pushed
the
migrate-dep-go
branch
13 times, most recently
from
32b9f6a to
fc25700
Compare
Since Go 1.11 there is a new way to structure packages, which don't require the project to live under `$GOPATH`, and provides version management. `go mod` could superseed `dep`, given it is builtin on the core tooling of the language and requires less dependencies to contribute. This commit follows the [migration instructions] to adopt `go mod`. The `README` has been updated, as well as `Makefile` and Travis configuration. The `main.go` has been moved into the root directory, so we are able to `go build` and produce the `terraform-provider-zerotier` binary, simplifying a lot the development. [migration instructions]: https://github.com/golang/go/wiki/Modules#migrating-to-modules
bltavares
force-pushed
the
migrate-dep-go
branch
from
fc25700 to
cfa85f6
Compare
bltavares
added a commit
to bltavares/terraform-provider-zerotier
that referenced
this pull request
Mar 16, 2019
Terraform [is able to import](https://www.terraform.io/docs/import/index.html) existing infrastructure. This allows you take resources you've created by some other means and bring it under Terraform management. This commit implements the `Importer` attribute for each resource, as documented by Terrafom ImporterPassthrough. Usage is documented on `README` as well. Closes cormacrelf#6 Built on top of: cormacrelf#7
Merged
bltavares
added a commit
to bltavares/terraform-provider-zerotier
that referenced
this pull request
Mar 17, 2019
Terraform [is able to import](https://www.terraform.io/docs/import/index.html) existing infrastructure. This allows you take resources you've created by some other means and bring it under Terraform management. This commit implements the `Importer` attribute for each resource, as documented by Terrafom ImporterPassthrough. Usage is documented on `README` as well. Closes cormacrelf#6 Built on top of: cormacrelf#7
cormacrelf
reviewed
Mar 20, 2019
See code review in cormacrelf#7 for why the `go.mod` indirects disappear.
|
I'm adding travis caching to speed things up a bit and because the first time I ran that other commit through it had an HTTP 500 error retrieving modules, but other than that, I think we're done here 👍 |
cormacrelf
added a commit
that referenced
this pull request
Mar 20, 2019
See code review in #7 for why the `go.mod` indirects disappear.
bltavares
added a commit
to bltavares/terraform-provider-zerotier
that referenced
this pull request
Mar 20, 2019
Terraform [is able to import](https://www.terraform.io/docs/import/index.html) existing infrastructure. This allows you take resources you've created by some other means and bring it under Terraform management. This commit implements the `Importer` attribute for each resource, as documented by Terrafom ImporterPassthrough. Usage is documented on `README` as well. Closes cormacrelf#6 Built on top of: cormacrelf#7
cormacrelf
pushed a commit
that referenced
this pull request
Mar 23, 2019
Terraform [is able to import](https://www.terraform.io/docs/import/index.html) existing infrastructure. This allows you take resources you've created by some other means and bring it under Terraform management. This commit implements the `Importer` attribute for each resource, as documented by Terrafom ImporterPassthrough. Usage is documented on `README` as well. Closes #6 Built on top of: #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Go 1.11 there is a new way to structure packages, which don't
require the project to live under
$GOPATH, and provides versionmanagement.
go modcould superseeddep, given it is builtin on the core toolingof the language and requires less dependencies to contribute.
This commit follows the migration instructions to adopt
go mod.The
READMEhas been updated, as well asMakefileand Travisconfiguration.
The
main.gohas been moved into the root directory, so we are able togo buildand produce theterraform-provider-zerotierbinary,simplifying a lot the development.