Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-koji-tagger: Update for schema changes #200

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

dustymabe
Copy link
Member

The schema of the message changed recently as explained to me:

Oh yes the format has changed indeed, you'll find the content of the
webhook in the "body" subkey, so message.body["body"]. The format change
is annoying indeed, but it gives you access to the webhook headers, and
lets the schema find out who is the agent of the change (for FMN).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This URL will hone in specifically on commits to the
fedora-coreos-config repo.
The schema of the message changed recently as explained to me:

> Oh yes the format has changed indeed, you'll find the content of the
> webhook in the "body" subkey, so message.body["body"]. The format change
> is annoying indeed, but it gives you access to the webhook headers, and
> lets the schema find out who is the agent of the change (for FMN).
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -49,7 +49,7 @@
ARCHES = ['x86_64', 'aarch64', 'ppc64le', 's390x']

# We are processing the org.fedoraproject.prod.github.push topic
# https://apps.fedoraproject.org/datagrepper/raw?topic=org.fedoraproject.prod.github.push&delta=100000
# https://apps.fedoraproject.org/datagrepper/v2/search?topic=org.fedoraproject.prod.github.push&contains=fedora-coreos-config&delta=100000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any messages at this new URL, but maybe there just haven't been any recently?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. I just enabled the push event to be sent to the new webhook yesterday.

@dustymabe dustymabe merged commit f41ff9b into coreos:main Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants