Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the azure-vm-utils package to support Azure NVMe Disks #3378

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

marmijo
Copy link
Member

@marmijo marmijo commented Feb 26, 2025

Add the azure-vm-utils package to include udev rules to support certain VM types (e.g. Standard_M16bds_v3, Standard_M16bs_v3, Standard_L8s_v4) that present managed disks as NVMe devices instead of traditional SCSI disks. Without these rules, LUN-based disk detection fails in the Azure Disk CSI driver, causing volume mount failures.

Add the azure provided udev rules[1] through the azure-vm-utils package. This package was recently built for Fedora 41, so let's also fast-track it in testing-devel to start consuming it sooner.

[1]: https://github.com/Azure/azure-vm-utils/blob/6fb0ae1d047c0f06e19aab8f1e27e2cd588a6f9f/udev/80-azure-disk.rules

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this..

Were we able to reproduce the error case and verify adding the rules here fixes it?

@marmijo
Copy link
Member Author

marmijo commented Feb 26, 2025

Were we able to reproduce the error case and verify adding the rules here fixes it?

I wasn't able to reproduce the exact issue, but I think I can confirm this fixes it. The issue is related to the Azure Disk CSI Driver not being able to perform LUN-based disk discovery without these udev rules. see: kubernetes-sigs/azuredisk-csi-driver#2777

I was able to confirm that the udev rules properly map NVMe devices in /dev/disk/azure and also sets AZURE_DISK_TYPE and AZURE_DISK_LUN to their proper values. These values are not set without the udev rules.

[core@marmijo-Standard_M16bds_v3 ~]$ udevadm info /dev/nvme0n2
M: nvme0n2
...
... (output truncated)
...
E: AZURE_DISK_TYPE=data
E: AZURE_DISK_LUN=0

@dustymabe
Copy link
Member

I was able to confirm that the udev rules properly map NVMe devices in /dev/disk/azure and also sets AZURE_DISK_TYPE and AZURE_DISK_LUN to their proper values. These values are not set without the udev rules.

IOW we have enough to write a simple test for this?

@marmijo
Copy link
Member Author

marmijo commented Feb 26, 2025

IOW we have enough to write a simple test for this?

Looks like it! 👍

The `azure-vm-utils` package provides Azure disk udev rules that support
NVMe backed Azure Managed Disks. A few newer VM types
(e.g. Standard_M16bds_v3, Standard_L8s_v4) present managed disks as NVMe
devices instead of traditional SCSI disks.

See: https://issues.redhat.com/browse/COS-3124
@marmijo marmijo force-pushed the add-az-vm-utils branch 2 times, most recently from 8066d48 to d6a67a2 Compare March 4, 2025 23:57
@marmijo marmijo changed the title Add support for Azure NVMe Disks Add the azure-vm-utils package to support Azure NVMe Disks Mar 5, 2025
This package was recently built for f41, so let's fast track it to start
consuming it in testing-devel.

see: https://issues.redhat.com/browse/COS-3124
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit a017c14 into coreos:testing-devel Mar 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants