Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testiso/iscsi add a manual test for no iBFT cases #3757

Merged
merged 1 commit into from
Apr 30, 2024
Merged

testiso/iscsi add a manual test for no iBFT cases #3757

merged 1 commit into from
Apr 30, 2024
+21 −8

Conversation

jbtrystram
Copy link
Contributor

This test simply changes the kargs from rd.iscsi.firmware=1 to netroot=iscsi... at the coreos-installer step.
This will ensure we support no-ibft installations.

Partial fix for coreos/fedora-coreos-tracker#1651

jlebon
jlebon previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some minor comments, but LGTM overall.

@jbtrystram
Copy link
Contributor Author

/restest

jlebon
jlebon previously approved these changes Mar 15, 2024
View reviewed changes
@jlebon
Copy link
Member

jlebon commented Mar 15, 2024

Let's clear up openshift/os#1461 (comment) before merging this so that we don't immediately break the RHCOS pipeline.

@jbtrystram
testiso/iscsi add a manual test for no iBFT cases

Unverified

The signing certificate or its chain could not be verified.
Certificate subject
Certificate issuer
CN sigstore-intermediate
O sigstore.dev
Learn about vigilant mode
Loading
Loading status checks…
649e463 
This test simply changes the kargs from `rd.iscsi.firmware=1` to
`netroot=iscsi...` at the coreos-installer step.
This will ensure we support no-ibft installations.

Partial fix for coreos/fedora-coreos-tracker#1651
@jbtrystram jbtrystram requested a review from dustymabe April 23, 2024 09:56
@jlebon
Copy link
Member

jlebon commented Apr 30, 2024

To confirm, did you verify that this passes on RHCOS?

jlebon
jlebon approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself LGTM!

@dustymabe
Copy link
Member

To confirm, did you verify that this passes on RHCOS?

tested on rhcos-416.94.202404301731-0-live.x86_64.iso:

Running test: iso-offline-install-iscsi.ibft.bios
PASS: iso-offline-install-iscsi.ibft.bios (3m23.07s)
Running test: iso-offline-install-iscsi.manual.bios
PASS: iso-offline-install-iscsi.manual.bios (3m15.665s)

@dustymabe dustymabe merged commit d0fc725 into coreos:main Apr 30, 2024
5 checks passed
@jbtrystram
Copy link
Contributor Author

To confirm, did you verify that this passes on RHCOS?

I think i did at the time, when opening the PR. Thanks @dustymabe for the confirmation

@dustymabe dustymabe mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon

@dustymabe dustymabe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbtrystram @jlebon @dustymabe @openshift-merge-robot