Fix deprecation warning in PHP 8.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
force-pushed
the
fix/php-8-compat-deprecation
branch
from
5b3143c to
fb246ae
Compare
|
I’m not sure if this is actually the correct fix. In PHP 8 the default value for Maybe we should just silence the deprecation instead? |
|
This is how Symfony handles it: symfony/translation@0411f10 |
|
OK, so as of libxml 2.9.0 entity substitution is disabled by default which makes disabling the entity loader unnecessary. The current fix in this PR should therefore be correct. |
leofeyer
reviewed
Sep 1, 2020
leofeyer
approved these changes
Sep 2, 2020
ausi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.