cmd/create: Mount a new devpts file system at /dev/pts #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Oct 14, 2020
As suggested by Giuseppe Scrivano. containers#581
debarshiray
force-pushed
the
wip/rishi/mount-devpts
branch
from
85c1704 to
83861ec
Compare
|
Build failed.
|
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Oct 14, 2020
As suggested by Giuseppe Scrivano. containers#581
debarshiray
force-pushed
the
wip/rishi/mount-devpts
branch
from
83861ec to
210134b
Compare
|
Build failed.
|
When the host's /dev directory is bind mounted into the toolbox container, then pseudo-terminal devices created for the container have their group ownership set to 'nobody'. This is because bind mounting /dev also pulls in the devpts file system at the host's /dev/pts, which is owned by the 'tty' group on the host. Since this GID is not available inside the container, it's represented as 'nobody'. This can be addressed by mounting a fresh devpts file system inside the toolbox container. It ensures that pseudo-terminal devices created for the container are owned by the container's 'tty' group. As suggested by Giuseppe Scrivano. containers#581
debarshiray
force-pushed
the
wip/rishi/mount-devpts
branch
from
210134b to
494007b
Compare
|
Build failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Giuseppe Scrivano.
However, I don't understand the issue well enough to actually come up with a meaningful commit message. We should at least explain the user-facing problem that this solves.