Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new tool installer #998

Merged
merged 40 commits into from
Jun 16, 2023
Merged

feat: new tool installer #998

merged 40 commits into from
Jun 16, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented May 25, 2023

First draft. This simply forwards to the bash installer for now.

@viceice viceice requested review from Chumper, JamieMagee and rarkins May 25, 2023 12:36
rarkins
rarkins reviewed May 25, 2023
View reviewed changes
@rarkins
Copy link
Member

rarkins commented May 26, 2023

Do you think you can make this so that it's a single command but with sub-commands? e.g. install, prepare, etc.?

@viceice
Copy link
Member Author

viceice commented May 26, 2023

Do you think you can make this so that it's a single command but with sub-commands? e.g. install, prepare, etc.?

I already did that with possible short link. So if you symlink the cli to install-tool you can call as now install-tool node.
otherwise you need to call containerbase-cli install tool node.

JamieMagee
JamieMagee reviewed May 29, 2023
View reviewed changes
JamieMagee
JamieMagee reviewed May 29, 2023
View reviewed changes
@JamieMagee
Copy link
Contributor

It looks like this is still CommonJS. What's preventing ESM?

JamieMagee
JamieMagee reviewed May 29, 2023
View reviewed changes
JamieMagee
JamieMagee reviewed May 29, 2023
View reviewed changes
@viceice viceice mentioned this pull request May 30, 2023
Closed
@JamieMagee
Copy link
Contributor

Is this ready for review?

@viceice
Copy link
Member Author

viceice commented Jun 6, 2023

Is this ready for review?

no, cache is still missing. will try to do tomorrow

@viceice viceice marked this pull request as ready for review June 16, 2023 12:29
@viceice viceice requested review from rarkins and JamieMagee June 16, 2023 12:29
@viceice
Copy link
Member Author

viceice commented Jun 16, 2023

currently only docker is converted as new tool. others will follow

@viceice viceice added this to the v9 milestone Jun 16, 2023
@viceice viceice merged commit a89c2ab into main Jun 16, 2023
@viceice viceice deleted the feat/tool-v3 branch June 16, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chumper Chumper Awaiting requested review from Chumper

@rarkins rarkins Awaiting requested review from rarkins

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9
Development

Successfully merging this pull request may close these issues.

Switch from bash scripts to higher language
3 participants
@viceice @rarkins @JamieMagee