Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete baseBalanceOf #311

Merged
merged 12 commits into from
Apr 22, 2022
Merged

delete baseBalanceOf #311

merged 12 commits into from
Apr 22, 2022

Conversation

scott-silver
Copy link
Contributor

No description provided.

@scott-silver scott-silver force-pushed the silver/delete-base-balance-of branch from d306c0f to c3e5b24 Compare April 18, 2022 19:40
@scott-silver scott-silver mentioned this pull request Apr 18, 2022
Merged
@scott-silver scott-silver force-pushed the silver/delete-base-balance-of branch 3 times, most recently from 435bcbb to 94f1fa1 Compare April 19, 2022 03:10
kevincheng96
kevincheng96 reviewed Apr 19, 2022
View reviewed changes
@scott-silver scott-silver changed the base branch from jflatow/accrue to main April 20, 2022 22:32
@scott-silver scott-silver force-pushed the silver/delete-base-balance-of branch 2 times, most recently from beb5140 to 4799cab Compare April 20, 2022 22:41
kevincheng96
kevincheng96 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scott-silver
Copy link
Contributor Author

This PR has a funny element to it; one of the flaky tests from #319 fails every time we run the Coverage job:

  1) accrue
       accrue initially succeeds and has the right parameters:
     AssertionError: expected 1650575142 to be close to 1650575224.854 +/- 80
      at Context.<anonymous> (test/accrue-test.ts:38:44)

The unit tests pass, but this flaky test always fails.

I'm fairly certain if I merge #319 and rebase this PR, it should pass the Coverage job. But I'm somewhat weirded out that a test could always pass when run with yarn test and always fail when run with yarn cover

@jflatow
Copy link
Contributor

jflatow commented Apr 22, 2022

This PR has a funny element to it; one of the flaky tests from #319 fails every time we run the Coverage job:

  1) accrue
       accrue initially succeeds and has the right parameters:
     AssertionError: expected 1650575142 to be close to 1650575224.854 +/- 80
      at Context.<anonymous> (test/accrue-test.ts:38:44)

The unit tests pass, but this flaky test always fails.

I'm fairly certain if I merge #319 and rebase this PR, it should pass the Coverage job. But I'm somewhat weirded out that a test could always pass when run with yarn test and always fail when run with yarn cover

Knowing that coverage tests run slower does it still weird you out?

@scott-silver scott-silver force-pushed the silver/delete-base-balance-of branch from 4799cab to 209e42c Compare April 22, 2022 16:19
@scott-silver
Copy link
Contributor Author

@jflatow nice, that makes sense

@scott-silver scott-silver merged commit 7802bd0 into main Apr 22, 2022
@jflatow jflatow deleted the silver/delete-base-balance-of branch May 18, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincheng96 kevincheng96 kevincheng96 approved these changes

@jflatow jflatow Awaiting requested review from jflatow

@hayesgm hayesgm Awaiting requested review from hayesgm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scott-silver @jflatow @kevincheng96