Add cluster volume type constant #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Jun 27, 2023
|
LGTM, need to be rebased as compose-spec schema was updated |
glours
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
LGTM, could you also open a PR to compose-spec/compose-spec repo adding this new value to the list of volume types?
Signed-off-by: Austin Raney <[email protected]>
glours
force-pushed
the
cluster-volume-type-constant
branch
from
4fb54b1 to
13c6919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster volumes were added to docker SwarmKit in 23.0 of docker engine. In short, cluster volumes enable use of container storage interface (CSI) volumes through docker's plugin system. This PR simply adds the
clustervolume type constant.