schema: add mapstructure struct tag to dockerfile_inline
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurazard
force-pushed
the
fix-dockerfile-inline
branch
from
fb37c12 to
2aa6a99
Compare
ndeloof
approved these changes
Apr 18, 2023
Without the proper struct tag the loader won't populate the `dockerfile_inline` field, and so this was not getting converted from the dict -> BuildConfig struct. Signed-off-by: Laura Brehm <[email protected]>
laurazard
force-pushed
the
fix-dockerfile-inline
branch
from
2aa6a99 to
565417c
Compare
|
I created #392 so we don't make such mistakes anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the proper struct tag the loader won't populate the
dockerfile_inlinefield, and so this wasn't getting converted from the dict ->BuildConfigstruct.Adds some tests as well.
related:
dockerfile_inlinefield in YAML #386cute animal even though it's not required: