refactor(localized-money-input): use hooks #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Jul 29, 2019
| const id = getFieldId(props, {}, sequentialId); | ||
|
|
||
| const hasErrorInRemainingLanguages = | ||
| props.hasError || | ||
| getHasErrorOnRemainingLanguages(props.errors, props.selectedLanguage); | ||
|
|
||
| if (hasErrorInRemainingLanguages) { | ||
| const shouldLanguagesExpand = |
There was a problem hiding this comment.
this was unnecessary. we are already inside of an if for hasErrorInRemainingLanguages, so there's no point of this
montezume
commented
Jul 29, 2019
|
|
||
| const [areLanguagesExpanded, setAreLanguagesExpanded] = React.useState( | ||
| const [areLanguagesExpanded, toggleLanguages] = useToggleState( |
There was a problem hiding this comment.
uses our toggleState hook instead
tdeekens
reviewed
Jul 29, 2019
| static defaultProps = { | ||
| horizontalConstraint: 'scale', | ||
| }; | ||
| const [areCurrenciesExpanded, toggleCurrencies] = useToggleState( |
| })} | ||
| </Spacings.Stack> | ||
| </Constraints.Horizontal> | ||
| LocalizedMoneyInput.parseMoneyValues = (moneyValues = [], locale) => |
There was a problem hiding this comment.
Ah. Was looking for where this went.
|
ah VRTs showed a problem with warning state |
montezume
commented
Jul 29, 2019
| ); | ||
| if (hasErrorInRemainingCurrencies || hasWarningInRemainingCurrencies) { | ||
| // this update within render replaces the old `getDerivedStateFromProps` functionality | ||
| // https://reactjs.org/docs/hooks-faq.html#how-do-i-implement-getderivedstatefromprops |
There was a problem hiding this comment.
we are here because one of these is true, so if we haven't already expanded currencies, we should expand
emmenko
approved these changes
Jul 29, 2019
tdeekens
approved these changes
Jul 30, 2019
islam3zzat
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
LocalizedMoneyInputcomponent to use hooks.