refactor(multiline-text-input): use hooks & expose useCollapsible hook
#966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
reviewed
Jul 27, 2019
| @@ -0,0 +1,12 @@ | |||
| import React from 'react'; | |||
|
|
|||
There was a problem hiding this comment.
Why do we put this into components? Would a hooks folder be more apt?
We could also call it useToggle I guess.
tdeekens
approved these changes
Jul 28, 2019
emmenko
reviewed
Jul 28, 2019
| @@ -0,0 +1,12 @@ | |||
| import React from 'react'; | |||
|
|
|||
| const useCollapsible = (defaultValue = true) => { | |||
There was a problem hiding this comment.
I’m wondering if we should name it like this or just something like useToggleState, because the hook itself does not do any “collapsible” work... 🤔
There was a problem hiding this comment.
yeah that makes sense.
jonnybel
approved these changes
Jul 29, 2019
emmenko
force-pushed
the
ml-multiline-text-input-hook
branch
from
f58729e to
708783b
Compare
emmenko
reviewed
Jul 29, 2019
| ControlledCollapsible.propTypes = collapsiblePropTypes; | ||
|
|
||
| const UncontrolledCollapsible = props => { | ||
| const [isOpen, toggle] = useToggleState(!props.isDefaultClosed); |
There was a problem hiding this comment.
I split the rendering into two components (controlled / uncontrolled) to fix the "conditional" rendering of the hook in the main component
emmenko
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
MutilineTextInputto use hooks, and exposes a newuseCollapsiblehook.