refactor(money-input): use hooks #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
reviewed
Jul 26, 2019
islam3zzat
reviewed
Jul 26, 2019
| } | ||
| } | ||
| }; | ||
| }, [props.id, props.name, props.value.amount]); |
There was a problem hiding this comment.
should we include the props.value.currencyCode?
There was a problem hiding this comment.
Yes we should include all the props used within the hook.
PS: do we have the eslint rules for hooks enabled?
| amountInputRef.current.focus(); | ||
| } | ||
| }, | ||
| [props.id, props.name] |
There was a problem hiding this comment.
should we add props.value.currencyCode and props.value.amount?
emmenko
reviewed
Jul 27, 2019
| display: flex; | ||
| `} | ||
| data-testid="money-input-container" | ||
| onBlur={event => { |
There was a problem hiding this comment.
Nitpick: our this event handler into a useCallback
| options={options} | ||
| placeholder="" | ||
| styles={currencySelectStyles} | ||
| onFocus={() => { |
emmenko
force-pushed
the
ml-money-input-hook
branch
from
a029e11 to
6400aa4
Compare
emmenko
reviewed
Jul 29, 2019
| handleAmountBlur = () => { | ||
| const amount = this.props.value.amount.trim(); | ||
| this.setState({ amountHasFocus: false }); | ||
| const { onChange } = props; |
emmenko
reviewed
Jul 29, 2019
| props.name, | ||
| props.value.amount, | ||
| props.value.currencyCode, | ||
| ]); |
emmenko
reviewed
Jul 29, 2019
| }); | ||
| } | ||
| }, | ||
| [onChange, props.id, props.name] |
emmenko
reviewed
Jul 29, 2019
| props.name, | ||
| props.value.amount, | ||
| props.value.currencyCode, | ||
| ] |
emmenko
approved these changes
Jul 29, 2019
tdeekens
approved these changes
Jul 29, 2019
|
The VRTs now render the
|
emmenko
force-pushed
the
ml-money-input-hook
branch
from
6400aa4 to
4d41155
Compare
jonnybel
approved these changes
Jul 29, 2019
islam3zzat
approved these changes
Jul 29, 2019
|
FYI: the only thing blocking this is approving the VRTs. Let's wait for @montezume maybe regarding that. |
|
Ah ok, I missed that issue I think. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
MoneyInputcomponent to use react hooks.