refactor(date-input): use hooks #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Jul 26, 2019
| inputRef.current.setSelectionRange(0, 100); | ||
| emit(date); | ||
| }, | ||
| [inputRef] |
There was a problem hiding this comment.
I'm not sure if this makes sense 🤔
There was a problem hiding this comment.
To my understanding yes. useCallback does not have smart exceptions like any value of props or any ref. It is just a closure and memoization as far as I understood it.
montezume
commented
Jul 26, 2019
| this.props.value === '' ? null : getDateInMonth(this.props.value) - 1, | ||
| }; | ||
|
|
||
| showPrevMonth = () => { |
There was a problem hiding this comment.
this was never used
montezume
commented
Jul 26, 2019
tdeekens
reviewed
Jul 27, 2019
| const nextDate = changeMonth(calendarDate, amount); | ||
| setCalendarDate(nextDate); | ||
| setHighlightedIndex(0); | ||
| }; |
There was a problem hiding this comment.
Is there a specific reason to not useCallback these two?
tdeekens
approved these changes
Jul 27, 2019
emmenko
force-pushed
the
ml-hooks-date-input
branch
from
ef38b1a to
6cefdef
Compare
emmenko
reviewed
Jul 29, 2019
| calendarDate: today, | ||
| highlightedIndex: | ||
| prevState.suggestedItems.length + getDateInMonth(today) - 1, | ||
| const { onChange } = props; |
There was a problem hiding this comment.
Yeah, this is how I would go about it too. Thanks.
emmenko
reviewed
Jul 29, 2019
| }, | ||
| }); | ||
| }; | ||
| }, [onBlur, props.id, props.name]); |
emmenko
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
DateInputcomponent to use hooks.