Fix id generation in NumberField and TextField #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it could happen that no id was generated when id={undefined} was passed explicitly. The tests were not catching that and were upgraded as well.
Previously it could happen that no id was generated when id={undefined} was passed explicitly. The tests were not catching that and were upgraded as well.
dferber90
force-pushed
the
df-fix-fields
branch
from
9050691 to
bc11914
Compare
montezume
reviewed
Sep 25, 2018
| @@ -8,7 +8,7 @@ states. | |||
| ## Usage | |||
|
|
|||
| ```js | |||
| import TextField from '@commercetools-frontend/ui-kit/fields/text-field'; | |||
| import { TextField } from '@commercetools-frontend/ui-kit'; | |||
lufego
pushed a commit
that referenced
this pull request
Oct 1, 2018
* docs(text-field): fix story
* fix(number-field): ensure id
Previously it could happen that no id was generated when id={undefined} was passed explicitly. The tests were not catching that and were upgraded as well.
* fix(text-field): ensure id
Previously it could happen that no id was generated when id={undefined} was passed explicitly. The tests were not catching that and were upgraded as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
idgeneration when noidprop is provided was broken inNumberFieldandTextField. The tests were not detecting this either.This PR fixes the generation, the tests and introduces
doexpressions to replace the iife.