docs: fix money input stories and docs #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dferber90
commented
Sep 25, 2018
| } else if (MoneyInput.isHighPrecision(formValues.price)) { | ||
| errors.price.unsupportedHighPrecision = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
Just reordered to be in line with the rest of the document.
| @@ -7,7 +7,7 @@ A controlled input component for money values with validation states. | |||
| ## Usage | |||
|
|
|||
| ```js | |||
| import MoneyInput from '@commercetools-frontend/ui-kit/inputs/money-input'; | |||
| import { MoneyInput } from '@commercetools-frontend/ui-kit'; | |||
There was a problem hiding this comment.
Fixed import path. See #90.
| | `isDisabled` | `bool` | - | - | `false` | Indicates that the field cannot be used. | | ||
| | `onBlur` | `func` | - | - | - | Called when the amount field or the currency code dropdown is blurred. | | ||
| | `onChange` | `function(event)` | ✳️ | - | - | Called with the event of the input or dropdown when either the currency or the amount have changed. Either `onChange` or `onChangeValue` must be passed. | | ||
| | `onChangeValue` | `function(nextValue: { currencyCode: string, amount: string })` | ✳️ | - | - | Called with the full value when either the currency or the amount have changed. Either `onChange` or `onChangeValue` must be passed. | |
There was a problem hiding this comment.
onChangeValue This does no longer exist and was removed. onChange was adapted as well.
| @@ -218,6 +218,8 @@ export default class MoneyInput extends React.Component { | |||
| return moneyValue && moneyValue.type === 'highPrecision'; | |||
| }; | |||
|
|
|||
| static isTouched = touched => touched && Object.values(touched).some(Boolean); | |||
There was a problem hiding this comment.
Moved it up so that all static methods used by consumers are grouped at the top.
| } else if (event.target.name.endsWith('.currencyCode')) { | ||
| ({ ...value, currencyCode: event.target.value }); | ||
| } | ||
| }; |
There was a problem hiding this comment.
This fixes the story.
lufego
pushed a commit
that referenced
this pull request
Oct 1, 2018
* docs(money-input): fix stories * docs(money-input): remove onChangeValue, fix onChange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
money-inputstory was broken. This PR fixes it.It further fixes the docs.