Improve form examples, add errors to FieldErrors, fix TextField #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dferber90
force-pushed
the
df-improve-form-examples
branch
from
a5b63eb to
1bb99ab
Compare
tdeekens
approved these changes
Sep 19, 2018
| isTouched={this.props.formik.touched.inventory} | ||
| errors={this.props.formik.errors.inventory} | ||
| renderError={key => { | ||
| switch (key) { |
There was a problem hiding this comment.
Starting to like render callbacks here. At first I was sceptical and wanted s component but they‘re easier on the consumer.
| // to accidental loss of data. By keeping the version in the form values | ||
| // instead an update of the version in the Apollo Cache does not affect the. | ||
| // form. On submission the version from the form values will be used, and the | ||
| // user will see the APIs ConcurrentModificationError as expected! |
lufego
approved these changes
Sep 24, 2018
This component will be used to show the errors of all fields.
dferber90
force-pushed
the
df-improve-form-examples
branch
from
a5ea9f7 to
3ec1735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storybook
Features
Fixes