Add NumberField #74
Merged
Add NumberField #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
approved these changes
Sep 18, 2018
| placeholder={this.props.placeholder} | ||
| horizontalConstraint="scale" | ||
| {...filterDataAttributes(this.props)} | ||
| /> | ||
| {this.renderErrors()} | ||
| <FieldErrors |
| import ErrorMessage from '../messages/error-message'; | ||
| import messages from './messages'; | ||
|
|
||
| const isObject = obj => typeof obj === 'object'; |
There was a problem hiding this comment.
Feels like this could as well be const hasErrors = errors => typeof errors !== 'object' || Object.keys(errors).length <= 0. Doesn't matter though I guess.
This component will be used to show the errors of all fields.
dferber90
force-pushed
the
df-number-field
branch
from
afab553 to
4243468
Compare
lufego
reviewed
Sep 24, 2018
lufego
pushed a commit
that referenced
this pull request
Oct 1, 2018
* feat(number-field): add component * feat(field-errors): extract component This component will be used to show the errors of all fields. * fix(number-field): adapt import paths * test(text-field): adapt to renderError prop * feat(number-field): export from entry-point * docs(number-field): fix example import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
NumberField, which is very similar to theTextFieldwe already have.