Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring(RadioInput): hovered and focus state changes #721

Merged
merged 4 commits into from
May 2, 2019

Conversation

montezume
Copy link
Contributor

@montezume montezume commented Apr 30, 2019

Summary

Better visual feedback for RadioOptions. Also makes them accessible with the keyboard.

Changes

  • Focus when input is in hasWarning or hasError states does a green underline

Design changes come from discussion with @mariabarrena

@montezume montezume changed the title radio option changes refactoring(RadioInput): hovered and focus state changes Apr 30, 2019
@montezume montezume requested a review from emmenko April 30, 2019 14:08
@montezume montezume force-pushed the ml-radio-option branch 3 times, most recently from 24d32ac to d412384 Compare May 2, 2019 07:06
@montezume montezume merged commit 2b49b6e into master May 2, 2019
@montezume montezume deleted the ml-radio-option branch May 2, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants