Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(collapsible-panel): add min-height #616

Merged
merged 1 commit into from
Mar 29, 2019
Merged

refactor(collapsible-panel): add min-height #616

merged 1 commit into from
Mar 29, 2019

Conversation

adnasa
Copy link
Contributor

@adnasa adnasa commented Mar 28, 2019

Summary

  • adds min-height of 32px on CollapsiblePanel's header section
    This is done to anticipate use cases that renders {Secondary|Primary}Button on the header

With this, we can experience that the header's height "jumps" when {Secondary|Primary}Button are conditionally rendered

@adnasa adnasa self-assigned this Mar 28, 2019
@adnasa adnasa requested review from montezume and Shecki March 28, 2019 15:12
@adnasa
Copy link
Contributor Author

adnasa commented Mar 28, 2019

:trollface:

@Shecki
Copy link

Shecki commented Mar 29, 2019

Normal Panel is fine with the 8px more. ✅
condensed-version should stay like it was ❌. (hope this is possible?)

@montezume
Copy link
Contributor

@Shecki yep, we can pass in isCondensed and set this conditionally. Nice catch 👏

qmateub
qmateub approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@qmateub qmateub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@montezume montezume self-requested a review March 29, 2019 08:36
montezume
montezume suggested changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@montezume montezume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use isCondensed to conditionally set the min height as requested by Sven?

@adnasa adnasa force-pushed the adnasa-impose-min-height-collapsiblepanel branch from 7962377 to 005d56b Compare March 29, 2019 10:43
@montezume
Copy link
Contributor

Maybe need to rebase to master for circle to pick up the build?

@adnasa adnasa force-pushed the adnasa-impose-min-height-collapsiblepanel branch from 005d56b to 3dd5856 Compare March 29, 2019 12:14
@adnasa
Copy link
Contributor Author

adnasa commented Mar 29, 2019

this unit_test step is taking ages..

@montezume montezume merged commit 48ca6b2 into master Mar 29, 2019
@montezume montezume deleted the adnasa-impose-min-height-collapsiblepanel branch March 29, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

@montezume montezume montezume approved these changes

@jonnybel jonnybel jonnybel approved these changes

@qmateub qmateub qmateub approved these changes

@Shecki Shecki Awaiting requested review from Shecki

Assignees

@adnasa adnasa

Labels
👶 good first contribution Good for newcomers 💅 Type: Enhancement Improves existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adnasa @Shecki @montezume @tdeekens @jonnybel @qmateub