Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(icons): renames icons #435

Merged
merged 2 commits into from
Jan 16, 2019
Merged

chore(icons): renames icons #435

merged 2 commits into from
Jan 16, 2019

Conversation

montezume
Copy link
Contributor

Summary

Renames some icons.

Details

BREAKING:

The following Icons have been renamed

FlagFulfilledIcon -> FlagFilledIcon
FlagIcon -> FlagLinearIcon
DoneIcon -> CheckThinIcon
SuccessIcon -> CheckBoldIcon
DeleteIcon -> BinLinearIcon
DeleteFilledIcon -> BinFilledIcon
AddIcon -> PlusThinIcon
AddBoldIcon -> PlusBoldIcon
PinActiveIcon -> PinLinearIcon
PinIcon -> PinFilled

@montezume
Copy link
Contributor Author

I would like to merge #438 first and then this

BREAKING:

The following Icons have been renamed

FlagFulfilledIcon -> FlagFilledIcon
FlagIcon -> FlagLinearIcon
DoneIcon -> CheckThinIcon
SuccessIcon -> CheckBoldIcon
DeleteIcon -> BinLinearIcon
DeleteFilledIcon -> BinFilledIcon
AddIcon -> PlusThinIcon
AddBoldIcon -> PlusBoldIcon
PinActiveIcon -> PinLinearIcon
PinIcon -> PinFilled
Copy link
Contributor

@dferber90 dferber90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have consistent names for peace of mind 🌳 🏡

@montezume montezume merged commit 68c6350 into master Jan 16, 2019
@montezume montezume deleted the ml-rename-cions branch January 16, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants