Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unsupported HorizontalConstraints #433

Merged
merged 30 commits into from
Jan 15, 2019
Merged

Drop unsupported HorizontalConstraints #433

merged 30 commits into from
Jan 15, 2019

Conversation

montezume
Copy link
Contributor

@montezume montezume commented Jan 14, 2019 •
edited
Loading

Remove unsupported horizontalConstraints

Closes #325

FieldLabel

Drop xs

Show screenshots

xs
screen shot 2019-01-14 at 10 24 36 am

Fields

Select fields

This covers AsyncCreatableSelectField,AsyncSelectField, CreatableSelectField and SelectInput

Drop xs

Show screenshots **xs**

screen shot 2019-01-14 at 10 28 05 am

Date inputs and fields

This covers DateField,DateRangeField and DateTimeField.

Drop xs, s

Show screenshots **xs**

screen shot 2019-01-14 at 10 37 56 am

s
screen shot 2019-01-14 at 10 38 01 am

Multiline text fields

This covers LocalizedMultilineField and MultilineTextField

  • (for any "localized" input, we need to drop xs and s because the bottom "show all languages" overlaps passed the S width anyways...

Drop xs and s

Show screenshots

xs

screen shot 2019-01-14 at 10 49 01 am

s

screen shot 2019-01-14 at 10 48 56 am

LocalizedTextField

  • (for any "localized" input, we need to drop xs and s because the bottom "show all languages" overlaps passed the S width anyways...
    Drop xs and s
Show screenshots

xs

screen shot 2019-01-14 at 10 53 05 am

s

screen shot 2019-01-14 at 10 53 09 am

MoneyField

Drop xs and s

Show screenshots

xs

screen shot 2019-01-14 at 10 54 13 am

s

screen shot 2019-01-14 at 10 54 17 am

NumberField

Drop xs

Show screenshots

xs

screen shot 2019-01-14 at 11 04 57 am

TextFields

Covers TextField and PasswordField

Drop xs

Show screenshots

xs

screen shot 2019-01-14 at 11 04 08 am

TimeField

Drop xs

Show screenshots

xs

screen shot 2019-01-14 at 11 05 51 am

Inputs

Select inputs

Covers AsyncCreatableSelectInput, AsyncSelectInput, SelectInput and CreatableSelectInput

Drop xs

Show screenshots

xs

screen shot 2019-01-14 at 11 07 57 am

Date Inputs

Covers DateInput, DateRangeInput and DateTimeInput

Drop xs, s

Show screenshots

xs

screen shot 2019-01-14 at 11 15 43 am

s

screen shot 2019-01-14 at 11 15 48 am

LocalizedMoneyInput

Drop xs, s

Show screenshots

xs

screen shot 2019-01-14 at 11 16 39 am

s

screen shot 2019-01-14 at 11 16 42 am

Multiline text inputs

This covers LocalizedMultilineInput and MultilineTextInput

Drop xs, s

Show screenshots

xs

screen shot 2019-01-14 at 11 20 03 am

s

screen shot 2019-01-14 at 11 20 08 am

Text Inputs

Covers TextInput and PasswordInput

Drop xs

Show screenshots

xs

screen shot 2019-01-14 at 11 22 50 am

TimeInput

Drop xs

Show screenshots

xs

screen shot 2019-01-14 at 11 23 16 am

@montezume montezume self-assigned this Jan 14, 2019
@montezume montezume changed the title Ml drop horz constraints Drop unsupported HorizontalConstraints Jan 14, 2019
dferber90
dferber90 approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@dferber90 dferber90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

tdeekens
tdeekens approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice!

@montezume montezume added the 👨‍🎨 Status: UI/UX Review Requires review from design team label Jan 14, 2019
@montezume
chore(field-label): drop xs as horizontal constraint
9dee7b5
@montezume
chore(async-creatable-select-field): drop xs horizontal constraint
c29a393
@montezume
chore(async-select-field): drop xs as horizontal constraint
a746a4c
@montezume
chore(creatable-select-field): drop support for xs horizontalConstr…
38274ee 
…aint

BREAKING CHANGE: No more support for `xs` horizontalConstraint
@montezume
chore(select-field): drop support for xs horizontal constraint
8698541 
BREAKING CHANGE: no more xs horizontal constraint
@montezume
chore(date-field): drop support for xs and s horizontal constraints
8974f77
@montezume
chore(date-range-field): drop support for xs and s horizontal con…
27c6156 
…straints
@montezume
chore(date-time-field): drop support for xs and s horizontalConst…
eaba739 
…raints
@montezume
chore(localized-multiline-text-field): remove support for xs and `s…
4765b8d 
…` horizontal constraints
@montezume
chore(multiline-text-field): drop support for xs and s horizontal…
c927e47 
… constraints
@montezume
chore: update readmes
1c6b7b6
@montezume
chore(localized-text-field): drop support for xs and s horizontal…
475f80d 
… constraints
@montezume
chore(money-field): drop support for xs and s horizontal constraints
85978d8
@montezume
chore(multiline-text-field): remove unsupported constraints
28ed317
@montezume
chore(number-field): drop support for xs horizontal constraint
8259382
@montezume
chore(text-field): drop support for xs horizontal constraint
6aa65aa
@montezume
chore(password-field): drop support for xs horizontal constrai
45299d4
@montezume
chore(time-field): drop support for xs horizontal constrai
1805398
@montezume
chore(async-creatable-select-field): drop xs horizontal constraint
97d8fb5
@montezume
chore(async--select-field): drop xs horizontal constraint
9e3d648
@montezume
chore(creatable-select-field): drop xs horizontal constraint
818f02f
@montezume
chore(select-field): drop xs horizontal constraint
dabfcf8
@montezume
chore(date-input): drop support for xs and s horizontal constraints
047ff13
@montezume
chore(date-range-input): drop support for xs and s horizontal con…
4e7825e 
…straints
@montezume
chore(date-time-input): drop support for xs and s horizontal cons…
936f76b 
…traints
@montezume
chore(localized-money-input): drop support for xs and s horizonta…
c9f8d80 
…l constraints
@montezume
chore(localized-multiline-text-input): drop support for xs and s …
266f32b 
…horizontal constraints
@montezume
chore(password-input): drop support for xs constraint
ed2825c
@montezume
chore(text-input): drop support for xs constraint
d04a468
@montezume montezume force-pushed the ml-drop-horz-constraints branch from 3e222b6 to f214e7c Compare January 15, 2019 09:04
@montezume montezume force-pushed the ml-drop-horz-constraints branch from f214e7c to e09a71d Compare January 15, 2019 09:20
@montezume montezume merged commit 7c53c7d into master Jan 15, 2019
@montezume montezume deleted the ml-drop-horz-constraints branch January 15, 2019 16:32
@tdeekens tdeekens mentioned this pull request Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dferber90 dferber90 dferber90 approved these changes

@tdeekens tdeekens tdeekens approved these changes

@filippobocik filippobocik filippobocik approved these changes

Assignees

@montezume montezume

Labels
👨‍🎨 Status: UI/UX Review Requires review from design team 💥 Type: Breaking Change 🔮 Type: Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@montezume @dferber90 @tdeekens @filippobocik