Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vrt): clarify scripts #417

Merged
merged 1 commit into from
Jan 9, 2019
Merged

docs(vrt): clarify scripts #417

merged 1 commit into from
Jan 9, 2019

Conversation

dferber90
Copy link
Contributor

  • Drops yarn test:visual script
  • Reorganizes order of scripts to group related scripts
  • Rewrites some documentation

After I tried to use VRT again, I struggled a little bit to see how the scripts are connected. I hope this rewrite of a part of the docs helps the next person.

yarn percy
```

You'll notice that we're not serving `visual-testing-app` here. Puppeteer does that for us, see `just-puppeteer.config.js`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dferber90 dferber90 force-pushed the df-improve-vrt-docs branch from 7075ae1 to ae4e21c Compare January 9, 2019 10:10
@dferber90 dferber90 merged commit 4f7fb7f into master Jan 9, 2019
@dferber90 dferber90 deleted the df-improve-vrt-docs branch January 9, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants