Reorganize README & CONTRIBUTING and add testing docs #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmenko
approved these changes
Dec 19, 2018
montezume
reviewed
Dec 19, 2018
dferber90
force-pushed
the
df-add-testing-docs
branch
from
77570bc to
b0495ef
Compare
dferber90
force-pushed
the
df-add-testing-docs
branch
from
382e880 to
4667015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganises the README by moving less relevant sections out to CONTRIBUTING or collapsing them behind a
detailscomponent.This PR also adds a new Testing section which explains the differences between our testing approaches and the decisions made there.
I've had this PR sitting for a while but wanted to wait until we've got Visual Regression Testing up and running.