Add type to buttons #349
Merged
Add type to buttons #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
previously requested changes
Dec 19, 2018
src/components/buttons/secondary-button/secondary-button.percy.js
Outdated
Show resolved
Hide resolved
montezume
force-pushed
the
df-add-type-to-buttons
branch
from
2768064 to
3787d47
Compare
|
Thanks for fixing things @montezume. Some tests broke due to the added warning (because we were passing |
montezume
reviewed
Dec 19, 2018
| @@ -343,7 +343,7 @@ describe('interaction', () => { | |||
| let wrapper; | |||
| describe('when not disabled', () => { | |||
| beforeEach(() => { | |||
| props = createProps({ linkTo: '/foo/bar' }); | |||
| props = createProps({ type: undefined, linkTo: '/foo/bar' }); | |||
tdeekens
approved these changes
Dec 19, 2018
BREAKING CHANGE: renamed type prop to tone
dferber90
force-pushed
the
df-add-type-to-buttons
branch
from
4870c81 to
622ba65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
typeprop to multiple buttons (FlatButton,IconButton,PrimaryButton,SecondaryButton,SecondaryIconButton) to enable using them as submit/reset buttons in forms.However the
FlatButtonalready had a prop calledtypewhich only supportedprimaryorsecondaryas values. That prop was renamed totone. The naming is not ideal but good enough until we redo the buttons. ThePrimaryButtonalso uses atoneprop at the moment. Note that the usage oftoneis a temporary change and is supposed to be redone once the buttons get reorganised.I further did not add a
typeprop to theLinkButtonas it's not really a button in the first place. It always renders a link. We should have a Link category and this should probably be aButtonLink(as it looks like a button but is a link).Closes #340
BREAKING CHANGE: The
typeprop ofFlatButtonwas renamed totone. A newtypeprop was added toFlatButtoninstead for which possible values aresubmit,resetandbutton.