Add DateRangeField #348
Merged
Add DateRangeField #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dferber90
added
👨👩👦👦 Status: Dev Review
👨🎨 Status: UI/UX Review
filippobocik
approved these changes
Dec 19, 2018
dferber90
force-pushed
the
df-add-date-range-field
branch
from
2564671 to
0d4923b
Compare
montezume
reviewed
Dec 19, 2018
| | Props | Type | Required | Values | Default | Description | | ||
| | ---------------------- | ------------------ | :------: | ---------------------------------- | ------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | `id` | `string` | - | - | - | Used as HTML `id` property. An `id` is auto-generated when it is not specified. | | ||
| | `horizontalConstraint` | `object` | | `xs`, `s`, `m`, `l`, `xl`, `scale` | `scale` | Horizontal size limit of the input fields. | |
There was a problem hiding this comment.
let's make our lives easier? #325
There was a problem hiding this comment.
I want to do that in one go at the end instead of having to think about it for every component now. I want to tackle it once for all fields instead of ending up with a mix of some components only offering the values they support while others still offer all values.
It's also easier to communicate that we didn't do this at all so far and will tackle it once later instead of trying to communicate that we only did it for some and not for others and then consumers can never be sure which ones are supported and which ones aren't.
montezume
reviewed
Dec 19, 2018
| static propTypes = { | ||
| // DateRangeField | ||
| id: PropTypes.string, | ||
| horizontalConstraint: PropTypes.oneOf(['xs', 's', 'm', 'l', 'xl', 'scale']), |
There was a problem hiding this comment.
I would remove support for the unsupported one here but 🤷♂️
montezume
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
DateRangeField