Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TimeField #346

Merged
merged 5 commits into from
Dec 18, 2018
Merged

Add TimeField #346

merged 5 commits into from
Dec 18, 2018

Conversation

dferber90
Copy link
Contributor

@dferber90 dferber90 commented Dec 18, 2018 •
edited
Loading

Add TimeField component.

image

"Unrelated" improvements:

  • adds onFocus to TimeInput
  • shows default placeholders in DateField story

tdeekens
tdeekens approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I guess rtl will come after.

montezume
montezume approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@montezume montezume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool with me. The RTL conversion can happen afterwards. Sidenote - we only have 8 more snaphots left this month 😱

@dferber90
Copy link
Contributor Author

Fixed some more things on this PR now (see description).

@dferber90 dferber90 merged commit 95fe46d into master Dec 18, 2018
@dferber90 dferber90 deleted the df-add-time-field branch December 18, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

@montezume montezume montezume approved these changes

@filippobocik filippobocik filippobocik approved these changes

Assignees
No one assigned
Labels
🚀 Type: New Feature Something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dferber90 @tdeekens @montezume @filippobocik