Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate CLIs from cac to commander #3072

Merged
merged 1 commit into from
Mar 13, 2025
Merged

refactor: migrate CLIs from cac to commander #3072

merged 1 commit into from
Mar 13, 2025
+47 −192

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Mar 12, 2025

Unfortunately the cac library hasn't been actively maintained in the past years. So we're back at using commander, which actually has a very similar API of cac so switching between them is pretty simple.

@emmenko emmenko requested a review from a team as a code owner March 12, 2025 14:34
@emmenko emmenko requested review from stephsprinkle, jaikamat, ddouglasz, tylermorrisford, ByronDWall and misama-ct and removed request for a team March 12, 2025 14:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6156158

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 1:46pm

@emmenko emmenko enabled auto-merge (squash) March 13, 2025 13:44
@emmenko emmenko merged commit 8f0acea into main Mar 13, 2025
8 checks passed
@emmenko emmenko deleted the nm-cli-commander branch March 13, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

@stephsprinkle stephsprinkle Awaiting requested review from stephsprinkle stephsprinkle is a code owner automatically assigned from commercetools/first-contact-team-fe

@jaikamat jaikamat Awaiting requested review from jaikamat jaikamat is a code owner automatically assigned from commercetools/first-contact-team-fe

@ddouglasz ddouglasz Awaiting requested review from ddouglasz ddouglasz is a code owner automatically assigned from commercetools/first-contact-team-fe

@tylermorrisford tylermorrisford Awaiting requested review from tylermorrisford tylermorrisford is a code owner automatically assigned from commercetools/first-contact-team-fe

@ByronDWall ByronDWall Awaiting requested review from ByronDWall ByronDWall is a code owner automatically assigned from commercetools/first-contact-team-fe

@misama-ct misama-ct Awaiting requested review from misama-ct misama-ct is a code owner automatically assigned from commercetools/first-contact-team-fe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmenko @tdeekens