Fix for Checkbox and Radio hovered, disabled states #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezume
commented
Dec 7, 2018
| @@ -11,11 +11,11 @@ | |||
| align-items: center; | |||
| } | |||
|
|
|||
| .checkboxWrapper svg [id='borderAndContent'] > [id='border'] { | |||
| .checkboxWrapper svg [id$='borderAndContent'] > [id$='border'] { | |||
montezume
force-pushed
the
ml-fix-checkboxes
branch
from
8cd72d5 to
1e4cbdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were using SVG ids to apply css styling to some of our svgs in the components
checkboxandradio. However, at some point in the last period of time since we last checked to see if this worked, SVGO moved to making SVG id's unique, by prepending them with the file name.We give id="borderAndContent", and SVGO outputs id="radio-option-default_react_svg__borderAndContent".
Approach
Use regex to target the id. ref
Add VRT tests for the two components.