refactor(icons): invalid names #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmenko
commented
Nov 26, 2018
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <svg width="24px" height="24px" viewBox="0 0 24 24" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <!-- Generator: sketchtool 45.2 (43514) - http://www.bohemiancoding.com/sketch --> | ||
| <title>arrow-left</title> |
There was a problem hiding this comment.
PS: the names here are still "wrong". Should we update them as well?
There was a problem hiding this comment.
Uff. Good one. No opinion 😐
There was a problem hiding this comment.
I went ahead and fixed the names: f38e012
I also noticed some inconsistency in the SVG structures. I already checked and notified the design team about it.
emmenko
commented
Nov 26, 2018
| <g id="Icons" stroke="none" stroke-width="1" fill-rule="evenodd"> | ||
| <g id="MC-icon-set" transform="translate(-24.000000, -936.000000)" fill="#000000"> | ||
| <g id="Directions" transform="translate(24.000000, 888.000000)"> | ||
| <g id="Arrow-Left" transform="translate(0.000000, 48.000000)"> |
tdeekens
approved these changes
Nov 26, 2018
emmenko
force-pushed
the
nm-fix-rename-icons
branch
from
f38e012 to
be5f2e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
Closes #260
Renamed icons listed here