chore: upgrade dependencies #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeekens
approved these changes
Nov 26, 2018
package.json
Outdated
| @@ -179,8 +179,8 @@ | |||
| "react-dom": "16.6.3", | |||
| "react-intl": "2.7.2", | |||
| "react-router-dom": "4.3.1", | |||
| "react-select": "2.1.1", | |||
| "react-testing-library": "5.2.3", | |||
| "react-select": "2.1.2", | |||
There was a problem hiding this comment.
Just to we are aware: having different versions of react-select here, in app-kit and in the mc-fe will mean we bundle react-select three times.
There was a problem hiding this comment.
I raised a chapter issue about this with Fedor.
There was a problem hiding this comment.
Thanks for the hint. I saw that already 👍
I don't think this PR will get merged soon. We pre-released v3 today (under the next dist-tag) and @montezume found some issues with trying to run it in app-kit:
Failed to compile.
../packages/application-shell/node_modules/@commercetools-frontend/ui-kit/dist/ui-kit.esm.js
Attempted import error: 'components' is not exported from 'react-select'.
We should figure that out first before merging this PR.
There was a problem hiding this comment.
react-select is not a peer dep anymore #263
Let's see if that works
emmenko
force-pushed
the
df-update-dependencies
branch
from
57e5285 to
0416889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257
Closes #256
Closes #255
Closes #254
Closes #253
Closes #252