Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove root from media queries #218

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Conversation

montezume
Copy link
Contributor

To make our media queries compatible with version 7 of postcss-custom-media.

After this is merged and released, we will update our webpack-config in merchant-center-application-kit to

postcssCustomMediaQueries({
  preserve: false,
  importFrom: [
    require.resolve(
      '@commercetools-frontend/ui-kit/materials/media-queries.mod.css'
    ),
  ],
}),

and update postcss-custom-media to version 7.0.6 (important), and remove the resolution for version 6 in the MC.

and then we can remove all of the @import's of media queries in the MC.

@montezume montezume force-pushed the ml-fix-media-queries branch from cfe139c to 3e375af Compare November 9, 2018 14:52
@montezume montezume merged commit 08d83bd into master Nov 9, 2018
@montezume montezume deleted the ml-fix-media-queries branch November 9, 2018 15:16
montezume added a commit that referenced this pull request Nov 9, 2018
@emmenko
Copy link
Member

emmenko commented Nov 9, 2018

Sounds like a plan! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants